diff options
| author | Gerd Hoffmann <kraxel@redhat.com> | 2016-02-16 14:25:00 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-03-03 15:06:52 -0800 |
| commit | ccaa0f16445bbe9abe2ce6c3be8038c635229a8a (patch) | |
| tree | e8b0e38aab1ea5c764e43df2bf999819ba394b4f | |
| parent | 8bdbb55d0555794ac7bc917d5aec4b1516eba14f (diff) | |
| download | lwn-ccaa0f16445bbe9abe2ce6c3be8038c635229a8a.tar.gz lwn-ccaa0f16445bbe9abe2ce6c3be8038c635229a8a.zip | |
drm/qxl: use kmalloc_array to alloc reloc_info in qxl_process_single_command
commit 34855706c30d52b0a744da44348b5d1cc39fbe51 upstream.
This avoids integer overflows on 32bit machines when calculating
reloc_info size, as reported by Alan Cox.
Cc: gnomes@lxorguk.ukuu.org.uk
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/gpu/drm/qxl/qxl_ioctl.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c b/drivers/gpu/drm/qxl/qxl_ioctl.c index 56a13a915155..0928c5e2bafd 100644 --- a/drivers/gpu/drm/qxl/qxl_ioctl.c +++ b/drivers/gpu/drm/qxl/qxl_ioctl.c @@ -168,7 +168,8 @@ static int qxl_process_single_command(struct qxl_device *qdev, cmd->command_size)) return -EFAULT; - reloc_info = kmalloc(sizeof(struct qxl_reloc_info) * cmd->relocs_num, GFP_KERNEL); + reloc_info = kmalloc_array(cmd->relocs_num, + sizeof(struct qxl_reloc_info), GFP_KERNEL); if (!reloc_info) return -ENOMEM; |