summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Daney <david.daney@cavium.com>2015-08-19 13:17:47 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-09-21 10:02:20 -0700
commitfe030b247003a9ef6396948a2ccd729de7392d9e (patch)
treec9b5548eedaad6d52ac6116bf1191a6e95f7a780
parentf3ba4ceb7b6e3e26b1131d051761b5bb60662dbb (diff)
downloadlwn-fe030b247003a9ef6396948a2ccd729de7392d9e.tar.gz
lwn-fe030b247003a9ef6396948a2ccd729de7392d9e.zip
of/address: Don't loop forever in of_find_matching_node_by_address().
commit 3a496b00b6f90c41bd21a410871dfc97d4f3c7ab upstream. If the internal call to of_address_to_resource() fails, we end up looping forever in of_find_matching_node_by_address(). This can be caused by a defective device tree, or calling with an incorrect matches argument. Fix by calling of_find_matching_node() unconditionally at the end of the loop. Signed-off-by: David Daney <david.daney@cavium.com> Signed-off-by: Rob Herring <robh@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/of/address.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/of/address.c b/drivers/of/address.c
index 005c65715846..9eae613c2a52 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -704,10 +704,10 @@ struct device_node *of_find_matching_node_by_address(struct device_node *from,
struct resource res;
while (dn) {
- if (of_address_to_resource(dn, 0, &res))
- continue;
- if (res.start == base_address)
+ if (!of_address_to_resource(dn, 0, &res) &&
+ res.start == base_address)
return dn;
+
dn = of_find_matching_node(dn, matches);
}