diff options
| author | Ted Juan <ted.juan@gmail.com> | 2014-06-20 17:32:05 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-07-28 08:06:03 -0700 |
| commit | f4a407b32de430e751a24e8d579af36ac74d99b3 (patch) | |
| tree | b036cd1d908a824f2bc3fd96a523fe89920b22f9 | |
| parent | 89d30c2107c85ce3ae1a267f1065aa0fb1e5b310 (diff) | |
| download | lwn-f4a407b32de430e751a24e8d579af36ac74d99b3.tar.gz lwn-f4a407b32de430e751a24e8d579af36ac74d99b3.zip | |
mtd: devices: elm: fix elm_context_save() and elm_context_restore() functions
commit 6938ad40cb97a52d88a763008935340729a4acc7 upstream.
These two function's switch case lack the 'break' that make them always
return error.
Signed-off-by: Ted Juan <ted.juan@gmail.com>
Acked-by: Pekon Gupta <pekon@ti.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/mtd/devices/elm.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c index d1dd6a33a050..3059a7a53bff 100644 --- a/drivers/mtd/devices/elm.c +++ b/drivers/mtd/devices/elm.c @@ -428,6 +428,7 @@ static int elm_context_save(struct elm_info *info) ELM_SYNDROME_FRAGMENT_1 + offset); regs->elm_syndrome_fragment_0[i] = elm_read_reg(info, ELM_SYNDROME_FRAGMENT_0 + offset); + break; default: return -EINVAL; } @@ -466,6 +467,7 @@ static int elm_context_restore(struct elm_info *info) regs->elm_syndrome_fragment_1[i]); elm_write_reg(info, ELM_SYNDROME_FRAGMENT_0 + offset, regs->elm_syndrome_fragment_0[i]); + break; default: return -EINVAL; } |