diff options
| author | Tomasz Nowicki <tomasz.nowicki@linaro.org> | 2014-02-10 14:00:11 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-03-06 22:06:23 -0800 |
| commit | 276826bee69b62789824cf6ab73b49a25e683f61 (patch) | |
| tree | cb5993de7482617c27148901401bc5f6224500d4 | |
| parent | 3404ec304327ac92e8da2fd250c5aa7a81229fde (diff) | |
| download | lwn-276826bee69b62789824cf6ab73b49a25e683f61.tar.gz lwn-276826bee69b62789824cf6ab73b49a25e683f61.zip | |
ACPI / PCI: Fix memory leak in acpi_pci_irq_enable()
commit b685f3b1744061aa9ad822548ba9c674de5be7c6 upstream.
acpi_pci_link_allocate_irq() can return negative gsi even if
entry != NULL. For that case we have a memory leak, so free
entry before returning from acpi_pci_irq_enable() for gsi < 0.
Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
[rjw: Subject and changelog]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/acpi/pci_irq.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c index 41c5e1b799ef..f658e0948703 100644 --- a/drivers/acpi/pci_irq.c +++ b/drivers/acpi/pci_irq.c @@ -432,6 +432,7 @@ int acpi_pci_irq_enable(struct pci_dev *dev) pin_name(pin)); } + kfree(entry); return 0; } |