diff options
| author | Alexander Usyskin <alexander.usyskin@intel.com> | 2014-01-27 22:27:23 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-02-22 13:34:52 -0800 |
| commit | badb44c0f55d06f049653c9a38d36cbbc07d0684 (patch) | |
| tree | fcd424f4836a805d1da1c6b802ce6f7621c60010 | |
| parent | 4675f7c7c248f53338a6b6ade156c6e98730999f (diff) | |
| download | lwn-badb44c0f55d06f049653c9a38d36cbbc07d0684.tar.gz lwn-badb44c0f55d06f049653c9a38d36cbbc07d0684.zip | |
mei: clear write cb from waiting list on reset
commit 30c54df7cb9b15b222529a028390b9c9582dd65e upstream.
Clear write callbacks sitting in write_waiting list on reset.
Otherwise these callbacks are left dangling and cause memory leak.
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/misc/mei/client.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index 87c96e4669e2..74e9e09e1a23 100644 --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -941,8 +941,16 @@ void mei_cl_all_wakeup(struct mei_device *dev) void mei_cl_all_write_clear(struct mei_device *dev) { struct mei_cl_cb *cb, *next; + struct list_head *list; - list_for_each_entry_safe(cb, next, &dev->write_list.list, list) { + list = &dev->write_list.list; + list_for_each_entry_safe(cb, next, list, list) { + list_del(&cb->list); + mei_io_cb_free(cb); + } + + list = &dev->write_waiting_list.list; + list_for_each_entry_safe(cb, next, list, list) { list_del(&cb->list); mei_io_cb_free(cb); } |