diff options
| author | Andy Whitcroft <apw@shadowen.org> | 2009-01-06 14:41:16 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-01-06 15:59:15 -0800 |
| commit | 721c1cb60e0546d2e71b9aa50426c94e69c6521a (patch) | |
| tree | 69c767f29569545e1ec8e950fce4b4a03ae970fe | |
| parent | 691d77b6b85c20e4166bafd12bd0131b28f95a16 (diff) | |
| download | lwn-721c1cb60e0546d2e71b9aa50426c94e69c6521a.tar.gz lwn-721c1cb60e0546d2e71b9aa50426c94e69c6521a.zip | |
checkpatch: comment detection may miss an implied comment on the last hunk
When detecting implied comments from leading stars we may incorrectly
think we have detected an edge one way or the other when we have not if we
drop off the end of the last hunk. Fix this up.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rwxr-xr-x | scripts/checkpatch.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 826cdbac0114..7c17e95bf36f 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1097,8 +1097,8 @@ sub process { $rawlines[$ln - 1] =~ /^-/); $cnt--; #print "RAW<$rawlines[$ln - 1]>\n"; - ($edge) = (defined $rawlines[$ln - 1] && - $rawlines[$ln - 1] =~ m@(/\*|\*/)@); + last if (!defined $rawlines[$ln - 1]); + ($edge) = ($rawlines[$ln - 1] =~ m@(/\*|\*/)@); last if (defined $edge); } if (defined $edge && $edge eq '*/') { |