diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2016-03-14 15:18:38 +0100 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-10-06 08:21:54 +0200 |
| commit | 93a443b33068176f332eabebe8da2060e983e18d (patch) | |
| tree | 89b7e510b31b7fa06d67fdf5ad1d485896c30073 | |
| parent | ea837f4b8359c3b30ccc3ed85ee6a06c33503a67 (diff) | |
| download | lwn-93a443b33068176f332eabebe8da2060e983e18d.tar.gz lwn-93a443b33068176f332eabebe8da2060e983e18d.zip | |
net: caif: fix misleading indentation
commit 8e0cc8c326d99e41468c96fea9785ab78883a281 upstream.
gcc points out code that is not indented the way it is
interpreted:
net/caif/cfpkt_skbuff.c: In function 'cfpkt_setlen':
net/caif/cfpkt_skbuff.c:289:4: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]
return cfpkt_getlen(pkt);
^~~~~~
net/caif/cfpkt_skbuff.c:286:3: note: ...this 'else' clause, but it is not
else
^~~~
It is clear from the context that not returning here would be
a bug, as we'd end up passing a negative length into a function
that takes a u16 length, so it is not missing curly braces
here, and I'm assuming that the indentation is the only part
that's wrong about it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | net/caif/cfpkt_skbuff.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c index 6493351f39c6..715251b72d7f 100644 --- a/net/caif/cfpkt_skbuff.c +++ b/net/caif/cfpkt_skbuff.c @@ -296,7 +296,7 @@ int cfpkt_setlen(struct cfpkt *pkt, u16 len) else skb_trim(skb, len); - return cfpkt_getlen(pkt); + return cfpkt_getlen(pkt); } /* Need to expand SKB */ |