diff options
| author | Jeff Mahoney <jeffm@suse.com> | 2016-08-02 14:05:33 -0700 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-09-29 14:42:22 +0200 |
| commit | 49680201829f0997cc75ab72fe385e0819d945c0 (patch) | |
| tree | 989cd838b24cfe170090da91ddc8f622fce9611b | |
| parent | 2d291fde5f706ac081e8cfc0ebe7e31dd534dfe7 (diff) | |
| download | lwn-49680201829f0997cc75ab72fe385e0819d945c0.tar.gz lwn-49680201829f0997cc75ab72fe385e0819d945c0.zip | |
reiserfs: fix "new_insert_key may be used uninitialized ..."
commit 0a11b9aae49adf1f952427ef1a1d9e793dd6ffb6 upstream.
new_insert_key only makes any sense when it's associated with a
new_insert_ptr, which is initialized to NULL and changed to a
buffer_head when we also initialize new_insert_key. We can key off of
that to avoid the uninitialized warning.
Link: http://lkml.kernel.org/r/5eca5ffb-2155-8df2-b4a2-f162f105efed@suse.com
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Jan Kara <jack@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | fs/reiserfs/ibalance.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/reiserfs/ibalance.c b/fs/reiserfs/ibalance.c index e1978fd895f5..58cce0c606f1 100644 --- a/fs/reiserfs/ibalance.c +++ b/fs/reiserfs/ibalance.c @@ -1082,8 +1082,9 @@ int balance_internal(struct tree_balance *tb, /* tree_balance structure insert_ptr); } - memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE); insert_ptr[0] = new_insert_ptr; + if (new_insert_ptr) + memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE); return order; } |