diff options
| author | Harvey Hunt <harvey.hunt@imgtec.com> | 2016-02-24 15:16:43 +0000 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-03-07 16:05:24 +0100 |
| commit | 54709aebcea1709772a302a9592d52a8252bc08d (patch) | |
| tree | 5b1949e86bb6d630c4e22e1224da6b75c2bf151d | |
| parent | a4b93e738aa086a155cbf143d47c88e63ab845a5 (diff) | |
| download | lwn-54709aebcea1709772a302a9592d52a8252bc08d.tar.gz lwn-54709aebcea1709772a302a9592d52a8252bc08d.zip | |
libata: Align ata_device's id on a cacheline
commit 4ee34ea3a12396f35b26d90a094c75db95080baa upstream.
The id buffer in ata_device is a DMA target, but it isn't explicitly
cacheline aligned. Due to this, adjacent fields can be overwritten with
stale data from memory on non coherent architectures. As a result, the
kernel is sometimes unable to communicate with an ATA device.
Fix this by ensuring that the id buffer is cacheline aligned.
This issue is similar to that fixed by Commit 84bda12af31f
("libata: align ap->sector_buf").
Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | include/linux/libata.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/libata.h b/include/linux/libata.h index 189c9ff97b29..a445209be917 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -712,7 +712,7 @@ struct ata_device { union { u16 id[ATA_ID_WORDS]; /* IDENTIFY xxx DEVICE data */ u32 gscr[SATA_PMP_GSCR_DWORDS]; /* PMP GSCR block */ - }; + } ____cacheline_aligned; /* DEVSLP Timing Variables from Identify Device Data Log */ u8 devslp_timing[ATA_LOG_DEVSLP_SIZE]; |