diff options
| author | Vasily Averin <vvs@virtuozzo.com> | 2016-01-14 13:41:14 +0300 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-02-24 10:29:18 +0100 |
| commit | ec6e80b82e3c3ee5ee5c1f38983eeb3e88d7851e (patch) | |
| tree | 061dc6c5d0de91716719ee4868634c2754db78a3 | |
| parent | d4cd077ac5077d1bb4c213413576012bbaec516c (diff) | |
| download | lwn-ec6e80b82e3c3ee5ee5c1f38983eeb3e88d7851e.tar.gz lwn-ec6e80b82e3c3ee5ee5c1f38983eeb3e88d7851e.zip | |
cifs_dbg() outputs an uninitialized buffer in cifs_readdir()
commit 01b9b0b28626db4a47d7f48744d70abca9914ef1 upstream.
In some cases tmp_bug can be not filled in cifs_filldir and stay uninitialized,
therefore its printk with "%s" modifier can leak content of kernelspace memory.
If old content of this buffer does not contain '\0' access bejond end of
allocated object can crash the host.
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Steve French <steve.french@primarydata.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | fs/cifs/readdir.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c index e327a9207ee1..5454aff19d18 100644 --- a/fs/cifs/readdir.c +++ b/fs/cifs/readdir.c @@ -849,6 +849,7 @@ int cifs_readdir(struct file *file, struct dir_context *ctx) * if buggy server returns . and .. late do we want to * check for that here? */ + *tmp_buf = 0; rc = cifs_filldir(current_entry, file, ctx, tmp_buf, max_len); if (rc) { |