diff options
| author | Tony Lindgren <tony@atomide.com> | 2015-11-30 21:39:53 -0800 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-02-24 10:23:15 +0100 |
| commit | b9485806adcc27a2ee6cdb6b87a90e67ad429b0e (patch) | |
| tree | 291447786ce3fa100fe00162d5dd1756508f69ff | |
| parent | c9ccd18aeaf036d6df0d762e3ba02aaa5a4a4596 (diff) | |
| download | lwn-b9485806adcc27a2ee6cdb6b87a90e67ad429b0e.tar.gz lwn-b9485806adcc27a2ee6cdb6b87a90e67ad429b0e.zip | |
phy: twl4030-usb: Relase usb phy on unload
commit b241d31ef2f6a289d33dcaa004714b26e06f476f upstream.
Otherwise rmmod omap2430; rmmod phy-twl4030-usb; modprobe omap2430
will try to use a non-existing phy and oops:
Unable to handle kernel paging request at virtual address b6f7c1f0
...
[<c048a284>] (devm_usb_get_phy_by_node) from [<bf0758ac>]
(omap2430_musb_init+0x44/0x2b4 [omap2430])
[<bf0758ac>] (omap2430_musb_init [omap2430]) from [<bf055ec0>]
(musb_init_controller+0x194/0x878 [musb_hdrc])
Cc: Bin Liu <b-liu@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: NeilBrown <neil@brown.name>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/usb/phy/phy-twl4030-usb.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy-twl4030-usb.c index 90730c8762b8..cb91d05fd177 100644 --- a/drivers/usb/phy/phy-twl4030-usb.c +++ b/drivers/usb/phy/phy-twl4030-usb.c @@ -732,6 +732,7 @@ static int twl4030_usb_remove(struct platform_device *pdev) struct twl4030_usb *twl = platform_get_drvdata(pdev); int val; + usb_remove_phy(&twl->phy); cancel_delayed_work(&twl->id_workaround_work); device_remove_file(twl->dev, &dev_attr_vbus); |