diff options
| author | Joe Thornber <ejt@redhat.com> | 2015-01-26 11:38:21 +0000 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-02-08 20:02:01 +0100 |
| commit | 5702185d1032c7d34adf38eb40e82dd0a474cdfc (patch) | |
| tree | 36d06bd2dc22367bfbbe9f45df230eb3d706b462 | |
| parent | 708dddc00d67f6e37261b4e9a6d5b7cf2853c63a (diff) | |
| download | lwn-5702185d1032c7d34adf38eb40e82dd0a474cdfc.tar.gz lwn-5702185d1032c7d34adf38eb40e82dd0a474cdfc.zip | |
dm thin: don't allow messages to be sent to a pool target in READ_ONLY or FAIL mode
commit 2a7eaea02b99b6e267b1e89c79acc6e9a51cee3b upstream.
You can't modify the metadata in these modes. It's better to fail these
messages immediately than let the block-manager deny write locks on
metadata blocks. Otherwise these failed metadata changes will trigger
'needs_check' to get set in the metadata superblock -- requiring repair
using the thin_check utility.
Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/md/dm-thin.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index 0396d7fc1d8b..d2b3563129c2 100644 --- a/drivers/md/dm-thin.c +++ b/drivers/md/dm-thin.c @@ -2507,6 +2507,12 @@ static int pool_message(struct dm_target *ti, unsigned argc, char **argv) struct pool_c *pt = ti->private; struct pool *pool = pt->pool; + if (get_pool_mode(pool) >= PM_READ_ONLY) { + DMERR("%s: unable to service pool target messages in READ_ONLY or FAIL mode", + dm_device_name(pool->pool_md)); + return -EINVAL; + } + if (!strcasecmp(argv[0], "create_thin")) r = process_create_thin_mesg(argc, argv, pool); |