diff options
| author | Long Li <longli@microsoft.com> | 2014-12-05 19:38:18 -0800 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-01-28 09:27:33 +0100 |
| commit | 2d4e63b5162415966a072d1a629ebdfe3bb18541 (patch) | |
| tree | cde87f4156f499f788533056fbebb9515b6be8f5 | |
| parent | 735beedafa629b508b26db5f735644a99e4f7cbd (diff) | |
| download | lwn-2d4e63b5162415966a072d1a629ebdfe3bb18541.tar.gz lwn-2d4e63b5162415966a072d1a629ebdfe3bb18541.zip | |
storvsc: ring buffer failures may result in I/O freeze
commit e86fb5e8ab95f10ec5f2e9430119d5d35020c951 upstream.
When ring buffer returns an error indicating retry, storvsc may not
return a proper error code to SCSI when bounce buffer is not used.
This has introduced I/O freeze on RAID running atop storvsc devices.
This patch fixes it by always returning a proper error code.
Signed-off-by: Long Li <longli@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/scsi/storvsc_drv.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index ed0f899e8aa5..86b05151fdab 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -1690,13 +1690,12 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd) if (ret == -EAGAIN) { /* no more space */ - if (cmd_request->bounce_sgl_count) { + if (cmd_request->bounce_sgl_count) destroy_bounce_buffer(cmd_request->bounce_sgl, cmd_request->bounce_sgl_count); - ret = SCSI_MLQUEUE_DEVICE_BUSY; - goto queue_error; - } + ret = SCSI_MLQUEUE_DEVICE_BUSY; + goto queue_error; } return 0; |