diff options
| author | Roland Dreier <roland@purestorage.com> | 2014-10-14 14:16:24 -0700 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-12-06 15:18:22 +0100 |
| commit | 63af3438d269f8a2c27ad1c2d5da7f4b190b8462 (patch) | |
| tree | c88f081e498c7a9e63b201c921bd7433a2ee1938 | |
| parent | 090ec5fef8c36ce8cac294eddaaacf1a1cb9e56e (diff) | |
| download | lwn-63af3438d269f8a2c27ad1c2d5da7f4b190b8462.tar.gz lwn-63af3438d269f8a2c27ad1c2d5da7f4b190b8462.zip | |
target: Don't call TFO->write_pending if data_length == 0
commit 885e7b0e181c14e4d0ddd26c688bad2b84c1ada9 upstream.
If an initiator sends a zero-length command (e.g. TEST UNIT READY) but
sets the transfer direction in the transport layer to indicate a
data-out phase, we still shouldn't try to transfer data. At best it's
a NOP, and depending on the transport, we might crash on an
uninitialized sg list.
Reported-by: Craig Watson <craig.watson@vanguard-rugged.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/target/target_core_transport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index b37371ee9f95..3931b50eeefd 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -2231,7 +2231,7 @@ transport_generic_new_cmd(struct se_cmd *cmd) * and let it call back once the write buffers are ready. */ target_add_to_state_list(cmd); - if (cmd->data_direction != DMA_TO_DEVICE) { + if (cmd->data_direction != DMA_TO_DEVICE || cmd->data_length == 0) { target_execute_cmd(cmd); return 0; } |