diff options
| author | Michael Ellerman <michael@ellerman.id.au> | 2013-09-25 19:24:17 +1000 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-11-19 17:02:03 +0100 |
| commit | b4dc3a3ad9a91453d3d72a6a3e5218d670dfc7dd (patch) | |
| tree | e56a11d4677c50609b051cbaebf4da515a23e8c0 | |
| parent | 1c854a6cd16b5096200fb47d1418b1d20f7df6bd (diff) | |
| download | lwn-b4dc3a3ad9a91453d3d72a6a3e5218d670dfc7dd.tar.gz lwn-b4dc3a3ad9a91453d3d72a6a3e5218d670dfc7dd.zip | |
hwrng: pseries - Return errors to upper levels in pseries-rng.c
commit d319fe2a0af3509f959d5195fb8916accbf14857 upstream.
We don't expect to get errors from the hypervisor when reading the rng,
but if we do we should pass the error up to the hwrng driver. Otherwise
the hwrng driver will continue calling us forever.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/char/hw_random/pseries-rng.c | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/drivers/char/hw_random/pseries-rng.c b/drivers/char/hw_random/pseries-rng.c index 5f1197929f0c..b761459a3436 100644 --- a/drivers/char/hw_random/pseries-rng.c +++ b/drivers/char/hw_random/pseries-rng.c @@ -17,6 +17,9 @@ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include <linux/kernel.h> #include <linux/module.h> #include <linux/hw_random.h> #include <asm/vio.h> @@ -25,10 +28,15 @@ static int pseries_rng_data_read(struct hwrng *rng, u32 *data) { - if (plpar_hcall(H_RANDOM, (unsigned long *)data) != H_SUCCESS) { - printk(KERN_ERR "pseries rng hcall error\n"); - return 0; + int rc; + + rc = plpar_hcall(H_RANDOM, (unsigned long *)data); + if (rc != H_SUCCESS) { + pr_err_ratelimited("H_RANDOM call failed %d\n", rc); + return -EIO; } + + /* The hypervisor interface returns 64 bits */ return 8; } |