diff options
| author | Andy Whitcroft <apw@canonical.com> | 2009-02-27 14:03:08 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-02-27 16:26:22 -0800 |
| commit | 667026e7b082ad59eb7194d6b5d159ed6c340e05 (patch) | |
| tree | 3d3cab494ac822aee47d65847a09ed2ac8fa6332 | |
| parent | a3340b35787975414d5f6fee83e00640688be2cb (diff) | |
| download | lwn-667026e7b082ad59eb7194d6b5d159ed6c340e05.tar.gz lwn-667026e7b082ad59eb7194d6b5d159ed6c340e05.zip | |
checkpatch: a modifier is not an identifier at the end of a type
We must make sure we do not misrecognise a modifier as an Identifier
when trying to match types. Prevent us matching this:
void * __ref
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rwxr-xr-x | scripts/checkpatch.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 15a590425129..b9e9ee1315b7 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1686,8 +1686,8 @@ sub process { # Modifiers should have spaces. $to =~ s/(\b$Modifier$)/$1 /; - #print "from<$from> to<$to>\n"; - if ($from ne $to) { + #print "from<$from> to<$to> ident<$ident>\n"; + if ($from ne $to && $ident !~ /^$Modifier$/) { ERROR("\"foo${from}bar\" should be \"foo${to}bar\"\n" . $herecurr); } } |