diff options
| author | Susant Sahani <susant@redhat.com> | 2014-05-10 00:11:32 +0530 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-05-29 11:49:31 +0200 |
| commit | 166c6b578bc07449529aa40ba524c694c2fd1623 (patch) | |
| tree | 821fa7c942c58905edb284afbbc7fa332b4dfbed | |
| parent | ce37c23f8c394e6bd271557044cbbdd0d2f7b9c9 (diff) | |
| download | lwn-166c6b578bc07449529aa40ba524c694c2fd1623.tar.gz lwn-166c6b578bc07449529aa40ba524c694c2fd1623.zip | |
ip6_tunnel: fix potential NULL pointer dereference
[ Upstream commit c8965932a2e3b70197ec02c6741c29460279e2a8 ]
The function ip6_tnl_validate assumes that the rtnl
attribute IFLA_IPTUN_PROTO always be filled . If this
attribute is not filled by the userspace application
kernel get crashed with NULL pointer dereference. This
patch fixes the potential kernel crash when
IFLA_IPTUN_PROTO is missing .
Signed-off-by: Susant Sahani <susant@redhat.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | net/ipv6/ip6_tunnel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index c1e11b5d6ccc..aac89c3c6af4 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c @@ -1549,7 +1549,7 @@ static int ip6_tnl_validate(struct nlattr *tb[], struct nlattr *data[]) { u8 proto; - if (!data) + if (!data || !data[IFLA_IPTUN_PROTO]) return 0; proto = nla_get_u8(data[IFLA_IPTUN_PROTO]); |