summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexandru Gheorghiu <gheorghiuandru@gmail.com>2013-03-09 13:57:28 +0200
committerTony Luck <tony.luck@intel.com>2013-03-11 12:13:21 -0700
commiteeb65d9cb5159752e672b5164110838bb5936a4a (patch)
treee1d2400c828ca0956f1bb3b7c39c04d3cb7ab988
parentf6161aa153581da4a3867a2d1a7caf4be19b6ec9 (diff)
downloadlwn-eeb65d9cb5159752e672b5164110838bb5936a4a.tar.gz
lwn-eeb65d9cb5159752e672b5164110838bb5936a4a.zip
fs: pstore: Replaced calls to kmalloc and memcpy with kmemdup
Replaced calls to kmalloc and memcpy with a single call to kmemdup. This patch was found using coccicheck. Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com> Acked-by: Kees Cook <keescook@chromium.org> Signed-off-by: Tony Luck <tony.luck@intel.com>
-rw-r--r--fs/pstore/ram.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 288f068740f6..38babb3a9384 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -156,10 +156,9 @@ static ssize_t ramoops_pstore_read(u64 *id, enum pstore_type_id *type,
time->tv_nsec = 0;
size = persistent_ram_old_size(prz);
- *buf = kmalloc(size, GFP_KERNEL);
+ *buf = kmemdup(persistent_ram_old(prz), size, GFP_KERNEL);
if (*buf == NULL)
return -ENOMEM;
- memcpy(*buf, persistent_ram_old(prz), size);
return size;
}