summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHeinz Mauelshagen <heinzm@redhat.com>2014-05-23 14:10:01 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-06-11 12:03:23 -0700
commit50faf9370b0aa357a9d114faafc2327505547928 (patch)
tree86cd0e1a24d6e6f65a3946a6bffa19a74e75a7d2
parentb1da22af26d907e88925c2ce1a9ee527bd899875 (diff)
downloadlwn-50faf9370b0aa357a9d114faafc2327505547928.tar.gz
lwn-50faf9370b0aa357a9d114faafc2327505547928.zip
dm cache: always split discards on cache block boundaries
commit f1daa838e861ae1a0fb7cd9721a21258430fcc8c upstream. The DM cache target cannot cope with discards that span multiple cache blocks, so each discard bio that spans more than one cache block must get split by the DM core. Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com> Acked-by: Joe Thornber <ejt@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/md/dm-cache-target.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index 1a75869d3a82..677973641d2b 100644
--- a/drivers/md/dm-cache-target.c
+++ b/drivers/md/dm-cache-target.c
@@ -1954,6 +1954,8 @@ static int cache_create(struct cache_args *ca, struct cache **result)
ti->num_discard_bios = 1;
ti->discards_supported = true;
ti->discard_zeroes_data_unsupported = true;
+ /* Discard bios must be split on a block boundary */
+ ti->split_discard_bios = true;
cache->features = ca->features;
ti->per_bio_data_size = get_per_bio_data_size(cache);