diff options
| author | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> | 2014-03-19 12:59:39 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-03-31 09:58:12 -0700 |
| commit | 62726e2fa1094a97e9313ea0abc41a5a42429fec (patch) | |
| tree | 14d96f8219597d421cf4e5f09bd2d3ba7e6e7807 | |
| parent | 10f8245e0d3650144b034142c8f91e5d15c392ab (diff) | |
| download | lwn-62726e2fa1094a97e9313ea0abc41a5a42429fec.tar.gz lwn-62726e2fa1094a97e9313ea0abc41a5a42429fec.zip | |
ALSA: compress: Pass through return value of open ops callback
commit 749d32237bf39e6576dd95bfdf24e4378e51716c upstream.
The snd_compr_open function would always return 0 even if the compressed
ops open function failed, obviously this is incorrect. Looks like this
was introduced by a small typo in:
commit a0830dbd4e42b38aefdf3fb61ba5019a1a99ea85
ALSA: Add a reference counter to card instance
This patch returns the value from the compressed op as it should.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | sound/core/compress_offload.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c index 19799931c51d..3fdf998ad057 100644 --- a/sound/core/compress_offload.c +++ b/sound/core/compress_offload.c @@ -133,7 +133,7 @@ static int snd_compr_open(struct inode *inode, struct file *f) kfree(data); } snd_card_unref(compr->card); - return 0; + return ret; } static int snd_compr_free(struct inode *inode, struct file *f) |