diff options
| author | Stephen Warren <swarren@nvidia.com> | 2014-02-13 16:54:24 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-03-31 09:58:13 -0700 |
| commit | 21680f38b5994c8d839380e7cf002496a51962a2 (patch) | |
| tree | c1940a12fbbaafff04c34a84e27fed47d7875daf | |
| parent | 27ff9f136acde1c1b5480f5fc3a874a7ca046f71 (diff) | |
| download | lwn-21680f38b5994c8d839380e7cf002496a51962a2.tar.gz lwn-21680f38b5994c8d839380e7cf002496a51962a2.zip | |
ASoC: max98090: make REVISION_ID readable
commit e126a646f77fdd66978785cb0a3a5e46b07aee2e upstream.
The REVISION_ID register is not currently marked readable. snd_soc_read()
refuses to read the register, and hence probe() fails.
Fixes: d4807ad2c4c0 ("regmap: Check readable regs in _regmap_read")
[exposed the bug, by checking for readability]
Fixes: 685e42154dcf ("ASoC: Replace max98090 Device Driver")
[left out this register from the readable list]
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | sound/soc/codecs/max98090.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index 819c90fe021f..4fdcc1cefc25 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -336,6 +336,7 @@ static bool max98090_readable_register(struct device *dev, unsigned int reg) case M98090_REG_RECORD_TDM_SLOT: case M98090_REG_SAMPLE_RATE: case M98090_REG_DMIC34_BIQUAD_BASE ... M98090_REG_DMIC34_BIQUAD_BASE + 0x0E: + case M98090_REG_REVISION_ID: return true; default: return false; |