summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIngo Molnar <mingo@elte.hu>2008-12-23 12:04:16 +0100
committerIngo Molnar <mingo@elte.hu>2008-12-23 12:45:08 +0100
commit8fb9331391af95ca1f4e5c0a0da8120b13cbae01 (patch)
treea0c0ac8e2dffd562ed023a012db3fd56540e7db6
parent94c46572a6d9bb497eda0a14099d9f1360d57d5d (diff)
downloadlwn-8fb9331391af95ca1f4e5c0a0da8120b13cbae01.tar.gz
lwn-8fb9331391af95ca1f4e5c0a0da8120b13cbae01.zip
perfcounters: remove warnings
Impact: remove debug checks Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--arch/x86/kernel/cpu/perf_counter.c7
-rw-r--r--include/linux/perf_counter.h4
-rw-r--r--kernel/perf_counter.c8
3 files changed, 0 insertions, 19 deletions
diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c
index bdbdb56eaa34..89fad5d4fb37 100644
--- a/arch/x86/kernel/cpu/perf_counter.c
+++ b/arch/x86/kernel/cpu/perf_counter.c
@@ -64,7 +64,6 @@ x86_perf_counter_update(struct perf_counter *counter,
{
u64 prev_raw_count, new_raw_count, delta;
- WARN_ON_ONCE(counter->state != PERF_COUNTER_STATE_ACTIVE);
/*
* Careful: an NMI might modify the previous counter value.
*
@@ -89,7 +88,6 @@ again:
* of the count, so we do that by clipping the delta to 32 bits:
*/
delta = (u64)(u32)((s32)new_raw_count - (s32)prev_raw_count);
- WARN_ON_ONCE((int)delta < 0);
atomic64_add(delta, &counter->count);
atomic64_sub(delta, &hwc->period_left);
@@ -193,7 +191,6 @@ __x86_perf_counter_disable(struct perf_counter *counter,
int err;
err = wrmsr_safe(hwc->config_base + idx, hwc->config, 0);
- WARN_ON_ONCE(err);
}
static DEFINE_PER_CPU(u64, prev_left[MAX_HW_COUNTERS]);
@@ -209,8 +206,6 @@ __hw_perf_counter_set_period(struct perf_counter *counter,
s32 left = atomic64_read(&hwc->period_left);
s32 period = hwc->irq_period;
- WARN_ON_ONCE(period <= 0);
-
/*
* If we are way outside a reasoable range then just skip forward:
*/
@@ -224,8 +219,6 @@ __hw_perf_counter_set_period(struct perf_counter *counter,
atomic64_set(&hwc->period_left, left);
}
- WARN_ON_ONCE(left <= 0);
-
per_cpu(prev_left[idx], smp_processor_id()) = left;
/*
diff --git a/include/linux/perf_counter.h b/include/linux/perf_counter.h
index f30486fc55d7..d038450de87d 100644
--- a/include/linux/perf_counter.h
+++ b/include/linux/perf_counter.h
@@ -218,8 +218,6 @@ struct perf_cpu_context {
extern int perf_max_counters;
#ifdef CONFIG_PERF_COUNTERS
-extern void
-perf_counter_show(struct perf_counter *counter, char *str, int trace);
extern const struct hw_perf_counter_ops *
hw_perf_counter_init(struct perf_counter *counter);
@@ -237,8 +235,6 @@ extern int perf_counter_task_enable(void);
#else
static inline void
-perf_counter_show(struct perf_counter *counter, char *str, int trace) { }
-static inline void
perf_counter_task_sched_in(struct task_struct *task, int cpu) { }
static inline void
perf_counter_task_sched_out(struct task_struct *task, int cpu) { }
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
index 5431e790b5d6..aab6c123b02c 100644
--- a/kernel/perf_counter.c
+++ b/kernel/perf_counter.c
@@ -861,8 +861,6 @@ static void task_clock_perf_counter_update(struct perf_counter *counter)
atomic64_set(&counter->hw.prev_count, now);
delta = now - prev;
- if (WARN_ON_ONCE(delta < 0))
- delta = 0;
atomic64_add(delta, &counter->count);
}
@@ -906,8 +904,6 @@ static void page_faults_perf_counter_update(struct perf_counter *counter)
atomic64_set(&counter->hw.prev_count, now);
delta = now - prev;
- if (WARN_ON_ONCE(delta < 0))
- delta = 0;
atomic64_add(delta, &counter->count);
}
@@ -954,8 +950,6 @@ static void context_switches_perf_counter_update(struct perf_counter *counter)
atomic64_set(&counter->hw.prev_count, now);
delta = now - prev;
- if (WARN_ON_ONCE(delta < 0))
- delta = 0;
atomic64_add(delta, &counter->count);
}
@@ -1000,8 +994,6 @@ static void cpu_migrations_perf_counter_update(struct perf_counter *counter)
atomic64_set(&counter->hw.prev_count, now);
delta = now - prev;
- if (WARN_ON_ONCE(delta < 0))
- delta = 0;
atomic64_add(delta, &counter->count);
}