diff options
| author | Roland Dreier <roland@purestorage.com> | 2011-11-22 13:51:33 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-12-21 12:58:29 -0800 |
| commit | 6764359b3a2840ea27cf09d1c4306598af8767bd (patch) | |
| tree | 02fa8fff0d967df12a2a7d0fd546affd266cd3e6 | |
| parent | 43dd6e6faffcacc6d8d9d12f15d6aa5f2f4fa351 (diff) | |
| download | lwn-6764359b3a2840ea27cf09d1c4306598af8767bd.tar.gz lwn-6764359b3a2840ea27cf09d1c4306598af8767bd.zip | |
target: Handle 0 correctly in transport_get_sectors_6()
commit 9b5cd7f37e1e018432111333e2a67f78ba41edfe upstream.
SBC-3 says:
A TRANSFER LENGTH field set to zero specifies that 256 logical
blocks shall be written. Any other value specifies the number
of logical blocks that shall be written.
The old code was always just returning the value in the TRANSFER LENGTH
byte. Fix this to return 256 if the byte is 0.
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/target/target_core_transport.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 42d9074f7ea4..e2added477b9 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -2562,10 +2562,15 @@ static inline u32 transport_get_sectors_6( /* * Everything else assume TYPE_DISK Sector CDB location. - * Use 8-bit sector value. + * Use 8-bit sector value. SBC-3 says: + * + * A TRANSFER LENGTH field set to zero specifies that 256 + * logical blocks shall be written. Any other value + * specifies the number of logical blocks that shall be + * written. */ type_disk: - return (u32)cdb[4]; + return cdb[4] ? : 256; } static inline u32 transport_get_sectors_10( |