summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@gmail.com>2011-12-08 08:04:12 -0500
committerGreg Kroah-Hartman <gregkh@suse.de>2011-12-21 12:58:31 -0800
commit584e8debed486b7ea98ba2d8dbf20e0a49d2798b (patch)
tree7635b9c322f86e12f7385765ba65c02e688c6db0
parent55f8ec6278236c45d82367cc6eca5028e1c7f87c (diff)
downloadlwn-584e8debed486b7ea98ba2d8dbf20e0a49d2798b.tar.gz
lwn-584e8debed486b7ea98ba2d8dbf20e0a49d2798b.zip
hwmon: (jz4740) fix signedness bug
commit 0b57d7602b68f7b2786b2f0e22da39cbd4139a95 upstream. wait_for_completion_interruptible_timeout() may return negative value. In this case, checking if (t > 0) will return true if t is unsigned. Signed-off-by: Axel Lin <axel.lin@gmail.com> Acked-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/hwmon/jz4740-hwmon.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/jz4740-hwmon.c b/drivers/hwmon/jz4740-hwmon.c
index fea292d43407..b65a4dae3f5e 100644
--- a/drivers/hwmon/jz4740-hwmon.c
+++ b/drivers/hwmon/jz4740-hwmon.c
@@ -59,7 +59,7 @@ static ssize_t jz4740_hwmon_read_adcin(struct device *dev,
{
struct jz4740_hwmon *hwmon = dev_get_drvdata(dev);
struct completion *completion = &hwmon->read_completion;
- unsigned long t;
+ long t;
unsigned long val;
int ret;