diff options
| author | Santiago Leon <santil@linux.vnet.ibm.com> | 2010-09-03 18:29:36 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-09-06 18:21:54 -0700 |
| commit | be35ae9e08dbbc70f1cd50de8639627fa501692d (patch) | |
| tree | 49be406d5b1b06104a4fcfd787755b81223f57f0 | |
| parent | f148f61d89995660e8aa20a2784ecd9c7f25e2a6 (diff) | |
| download | lwn-be35ae9e08dbbc70f1cd50de8639627fa501692d.tar.gz lwn-be35ae9e08dbbc70f1cd50de8639627fa501692d.zip | |
ibmveth: Return -EINVAL on all ->probe errors
We had a few cases where we returned success on error.
Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Santiago Leon <santil@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ibmveth.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c index 8adfff55792d..11086dbe76e8 100644 --- a/drivers/net/ibmveth.c +++ b/drivers/net/ibmveth.c @@ -1392,7 +1392,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, NULL); if (!mac_addr_p) { dev_err(&dev->dev, "Can't find VETH_MAC_ADDR attribute\n"); - return 0; + return -EINVAL; } mcastFilterSize_p = (unsigned int *)vio_get_attribute(dev, @@ -1400,7 +1400,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, if (!mcastFilterSize_p) { dev_err(&dev->dev, "Can't find VETH_MCAST_FILTER_SIZE " "attribute\n"); - return 0; + return -EINVAL; } netdev = alloc_etherdev(sizeof(struct ibmveth_adapter)); |