diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-04-29 16:21:07 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-05-19 10:04:48 -0700 |
| commit | 5cb2df345fb2b2e119f492d6c36e8d3bad70d8b3 (patch) | |
| tree | ac185653f917b4e7d32299c00ac5bbbd90070837 | |
| parent | d8b1123f949c5463421ec0a66bbca21e0a5feba0 (diff) | |
| download | lwn-5cb2df345fb2b2e119f492d6c36e8d3bad70d8b3.tar.gz lwn-5cb2df345fb2b2e119f492d6c36e8d3bad70d8b3.zip | |
drivers/rtc/rtc-pcf2123.c: fix error return code in pcf2123_probe()
commit 35623715818dfa720cccf99cd280dcbb4b78da23 upstream.
Fix to return -ENODEV in the chip not found error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Cc: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/rtc/rtc-pcf2123.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index 71bab0ef5443..646f6fe52cf2 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/rtc/rtc-pcf2123.c @@ -263,6 +263,7 @@ static int __devinit pcf2123_probe(struct spi_device *spi) if (!(rxbuf[0] & 0x20)) { dev_err(&spi->dev, "chip not found\n"); + ret = -ENODEV; goto kfree_exit; } |