diff options
| author | Nithin Nayak Sujir <nsujir@broadcom.com> | 2013-01-14 17:10:59 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-02-14 10:47:37 -0800 |
| commit | 98d5919834d6091f0a4144ebd3c2c17f1b883d84 (patch) | |
| tree | f84b444e51f1fce571a58266c55bb42387d14059 | |
| parent | 98df2584aaa730220adc29a7fbfa1c551fee5930 (diff) | |
| download | lwn-98d5919834d6091f0a4144ebd3c2c17f1b883d84.tar.gz lwn-98d5919834d6091f0a4144ebd3c2c17f1b883d84.zip | |
tg3: Avoid null pointer dereference in tg3_interrupt in netconsole mode
[ Upstream commit 9c13cb8bb477a83b9a3c9e5a5478a4e21294a760 ]
When netconsole is enabled, logging messages generated during tg3_open
can result in a null pointer dereference for the uninitialized tg3
status block. Use the irq_sync flag to disable polling in the early
stages. irq_sync is cleared when the driver is enabling interrupts after
all initialization is completed.
Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/net/tg3.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 10a99e4434db..81e19d44e584 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -5662,6 +5662,9 @@ static void tg3_poll_controller(struct net_device *dev) int i; struct tg3 *tp = netdev_priv(dev); + if (tg3_irq_sync(tp)) + return; + for (i = 0; i < tp->irq_cnt; i++) tg3_interrupt(tp->napi[i].irq_vec, &tp->napi[i]); } @@ -14981,6 +14984,7 @@ static int __devinit tg3_init_one(struct pci_dev *pdev, tp->pm_cap = pm_cap; tp->rx_mode = TG3_DEF_RX_MODE; tp->tx_mode = TG3_DEF_TX_MODE; + tp->irq_sync = 1; if (tg3_debug > 0) tp->msg_enable = tg3_debug; |