diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2011-09-19 17:04:37 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-12-21 12:57:40 -0800 |
| commit | b2c51348a4e6b08bb493b2b33d06df89d1a9a0bc (patch) | |
| tree | 82fe8ebc70b477d46156a4290bb66c21abed9300 | |
| parent | b98eb43012d8679aa6c9e5527a7cc5706ee192f6 (diff) | |
| download | lwn-b2c51348a4e6b08bb493b2b33d06df89d1a9a0bc.tar.gz lwn-b2c51348a4e6b08bb493b2b33d06df89d1a9a0bc.zip | |
Make TASKSTATS require root access
commit 1a51410abe7d0ee4b1d112780f46df87d3621043 upstream.
Ok, this isn't optimal, since it means that 'iotop' needs admin
capabilities, and we may have to work on this some more. But at the
same time it is very much not acceptable to let anybody just read
anybody elses IO statistics quite at this level.
Use of the GENL_ADMIN_PERM suggested by Johannes Berg as an alternative
to checking the capabilities by hand.
Reported-by: Vasiliy Kulikov <segoon@openwall.com>
Cc: Johannes Berg <johannes.berg@intel.com>
Acked-by: Balbir Singh <bsingharora@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Moritz Mühlenhoff <jmm@inutil.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | kernel/taskstats.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/taskstats.c b/kernel/taskstats.c index fc0f22005417..8d597b19f13c 100644 --- a/kernel/taskstats.c +++ b/kernel/taskstats.c @@ -657,6 +657,7 @@ static struct genl_ops taskstats_ops = { .cmd = TASKSTATS_CMD_GET, .doit = taskstats_user_cmd, .policy = taskstats_cmd_get_policy, + .flags = GENL_ADMIN_PERM, }; static struct genl_ops cgroupstats_ops = { |