diff options
author | Xi Wang <xi.wang@gmail.com> | 2011-12-12 21:55:52 +0000 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2012-01-12 11:35:55 -0800 |
commit | 6e474bc4d5c0d94c070a18901e00ff33de0c1be1 (patch) | |
tree | 88bd52502d438e5046c10d7f4c99a1454d06324a | |
parent | 68f760945cb704f4a9d0ae7c4abc9e41ca30aa91 (diff) | |
download | lwn-6e474bc4d5c0d94c070a18901e00ff33de0c1be1.tar.gz lwn-6e474bc4d5c0d94c070a18901e00ff33de0c1be1.zip |
xfs: fix acl count validation in xfs_acl_from_disk()
commit 093019cf1b18dd31b2c3b77acce4e000e2cbc9ce upstream.
Commit fa8b18ed didn't prevent the integer overflow and possible
memory corruption. "count" can go negative and bypass the check.
Signed-off-by: Xi Wang <xi.wang@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | fs/xfs/linux-2.6/xfs_acl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/linux-2.6/xfs_acl.c b/fs/xfs/linux-2.6/xfs_acl.c index 4b9fb915d445..f86e03487866 100644 --- a/fs/xfs/linux-2.6/xfs_acl.c +++ b/fs/xfs/linux-2.6/xfs_acl.c @@ -39,7 +39,7 @@ xfs_acl_from_disk(struct xfs_acl *aclp) struct posix_acl_entry *acl_e; struct posix_acl *acl; struct xfs_acl_entry *ace; - int count, i; + unsigned int count, i; count = be32_to_cpu(aclp->acl_cnt); if (count > XFS_ACL_MAX_ENTRIES) |