diff options
author | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2010-08-16 20:26:51 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-10-28 21:51:26 -0700 |
commit | ad2f6a9c0d0f32a05fbd033dfd0c8ac41e635125 (patch) | |
tree | 9fb28c3de5a07edf911c27d7e297d56af775d87e | |
parent | f4604440d6512452e75675272364f14af3521af0 (diff) | |
download | lwn-ad2f6a9c0d0f32a05fbd033dfd0c8ac41e635125.tar.gz lwn-ad2f6a9c0d0f32a05fbd033dfd0c8ac41e635125.zip |
mfd: Ignore non-GPIO IRQs when setting wm831x IRQ types
commit c9d66d3515bbb0ad8062721487de7ade02d2b936 upstream.
The driver was originally tested with an additional patch which
made this unneeded but that patch had issuges and got lost on the
way to mainline, causing problems when the errors are reported.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/mfd/wm831x-irq.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/mfd/wm831x-irq.c b/drivers/mfd/wm831x-irq.c index 7dabe4dbd373..294183b6260b 100644 --- a/drivers/mfd/wm831x-irq.c +++ b/drivers/mfd/wm831x-irq.c @@ -394,8 +394,13 @@ static int wm831x_irq_set_type(unsigned int irq, unsigned int type) irq = irq - wm831x->irq_base; - if (irq < WM831X_IRQ_GPIO_1 || irq > WM831X_IRQ_GPIO_11) - return -EINVAL; + if (irq < WM831X_IRQ_GPIO_1 || irq > WM831X_IRQ_GPIO_11) { + /* Ignore internal-only IRQs */ + if (irq >= 0 && irq < WM831X_NUM_IRQS) + return 0; + else + return -EINVAL; + } switch (type) { case IRQ_TYPE_EDGE_BOTH: |