diff options
| author | Alex Deucher <alexdeucher@gmail.com> | 2010-09-27 10:57:10 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-10-28 21:51:34 -0700 |
| commit | 0097ad30cacd143b61ae58f0e9830ae8be3c6c79 (patch) | |
| tree | 69e805e356acafebb766393758d072aaad4fa492 | |
| parent | f68f4a26c5390ce47f6b4ffefb1bf35e7cac93be (diff) | |
| download | lwn-0097ad30cacd143b61ae58f0e9830ae8be3c6c79.tar.gz lwn-0097ad30cacd143b61ae58f0e9830ae8be3c6c79.zip | |
drm/radeon/kms: fix potential segfault in r600_ioctl_wait_idle
commit e488459a0e131acc9e14df093cfee740bc431953 upstream.
radeon_gem_wait_idle_ioctl can apparently get called prior to
the vram page being set up or even if accel if false, so make
sure it's valid before using it.
Should fix:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=597636
https://bugs.freedesktop.org/show_bug.cgi?id=29834
Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/gpu/drm/radeon/r600.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index 952cc780230f..eddeff34e73a 100644 --- a/drivers/gpu/drm/radeon/r600.c +++ b/drivers/gpu/drm/radeon/r600.c @@ -3522,7 +3522,8 @@ void r600_ioctl_wait_idle(struct radeon_device *rdev, struct radeon_bo *bo) /* r7xx hw bug. write to HDP_DEBUG1 followed by fb read * rather than write to HDP_REG_COHERENCY_FLUSH_CNTL */ - if ((rdev->family >= CHIP_RV770) && (rdev->family <= CHIP_RV740)) { + if ((rdev->family >= CHIP_RV770) && (rdev->family <= CHIP_RV740) && + rdev->vram_scratch.ptr) { void __iomem *ptr = (void *)rdev->vram_scratch.ptr; u32 tmp; |