diff options
| author | Alex Williamson <alex.williamson@redhat.com> | 2011-03-04 14:52:30 -0700 |
|---|---|---|
| committer | Andi Kleen <ak@linux.intel.com> | 2011-04-28 08:21:11 -0700 |
| commit | e77004d6125829cc856553e08fb2d5d2afb2e289 (patch) | |
| tree | d458c6471de3d1945464ed9925f522bf00860818 | |
| parent | 8e2f9d0be8626aca810c8cac38fce207ea81af4a (diff) | |
| download | lwn-e77004d6125829cc856553e08fb2d5d2afb2e289.tar.gz lwn-e77004d6125829cc856553e08fb2d5d2afb2e289.zip | |
intel-iommu: Fix get_domain_for_dev() error path
commit 2fe9723df8e45fd247782adea244a5e653c30bf4 upstream.
If we run out of domain_ids and fail iommu_attach_domain(), we
fall into domain_exit() without having setup enough of the
domain structure for this to do anything useful. In fact, it
typically runs off into the weeds walking the bogus domain->devices
list. Just free the domain.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Acked-by: Donald Dutile <ddutile@redhat.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
| -rw-r--r-- | drivers/pci/intel-iommu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c index 50e083e4208c..83ac0a08f701 100644 --- a/drivers/pci/intel-iommu.c +++ b/drivers/pci/intel-iommu.c @@ -1835,7 +1835,7 @@ static struct dmar_domain *get_domain_for_dev(struct pci_dev *pdev, int gaw) ret = iommu_attach_domain(domain, iommu); if (ret) { - domain_exit(domain); + free_domain_mem(domain); goto error; } |