diff options
| author | Oliver Hartkopp <socketcan@hartkopp.net> | 2010-11-10 12:10:30 +0000 |
|---|---|---|
| committer | Andi Kleen <ak@linux.intel.com> | 2010-12-14 23:40:17 +0100 |
| commit | c4b9d85475fe417aa1d4325e350b6bff78a70c17 (patch) | |
| tree | 5b3a8f5d3e728eb3c7908a96917c1f9f22054ab7 | |
| parent | 7bac9815cc7489f880db12ada19b3f10d1db1629 (diff) | |
| download | lwn-c4b9d85475fe417aa1d4325e350b6bff78a70c17.tar.gz lwn-c4b9d85475fe417aa1d4325e350b6bff78a70c17.zip | |
can-bcm: fix minor heap overflow
commit 0597d1b99fcfc2c0eada09a698f85ed413d4ba84 upstream.
On 64-bit platforms the ASCII representation of a pointer may be up to 17
bytes long. This patch increases the length of the buffer accordingly.
http://marc.info/?l=linux-netdev&m=128872251418192&w=2
Reported-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
CC: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | net/can/bcm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/can/bcm.c b/net/can/bcm.c index 08ffe9e4be20..6faa8256e10c 100644 --- a/net/can/bcm.c +++ b/net/can/bcm.c @@ -125,7 +125,7 @@ struct bcm_sock { struct list_head tx_ops; unsigned long dropped_usr_msgs; struct proc_dir_entry *bcm_proc_read; - char procname [9]; /* pointer printed in ASCII with \0 */ + char procname [20]; /* pointer printed in ASCII with \0 */ }; static inline struct bcm_sock *bcm_sk(const struct sock *sk) |