diff options
| author | Bernd Schubert <bernd.schubert@itwm.fraunhofer.de> | 2012-09-26 21:24:57 -0400 |
|---|---|---|
| committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2014-02-10 16:11:29 -0500 |
| commit | c26795029709e433ff88a436ca935b215e81c8f2 (patch) | |
| tree | 57fae27eacf8f90fef86482977e50a292ed00620 | |
| parent | faf16058ac73346057ac1c4f5126c0769c1f75e7 (diff) | |
| download | lwn-c26795029709e433ff88a436ca935b215e81c8f2.tar.gz lwn-c26795029709e433ff88a436ca935b215e81c8f2.zip | |
ext4: always set i_op in ext4_mknod()
commit 6a08f447facb4f9e29fcc30fb68060bb5a0d21c2 upstream.
ext4_special_inode_operations have their own ifdef CONFIG_EXT4_FS_XATTR
to mask those methods. And ext4_iget also always sets it, so there is
an inconsistency.
Signed-off-by: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
| -rw-r--r-- | fs/ext4/namei.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 41198b355a26..683c0f9d8a83 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -1825,9 +1825,7 @@ retry: err = PTR_ERR(inode); if (!IS_ERR(inode)) { init_special_inode(inode, inode->i_mode, rdev); -#ifdef CONFIG_EXT4_FS_XATTR inode->i_op = &ext4_special_inode_operations; -#endif err = ext4_add_nondir(handle, dentry, inode); } ext4_journal_stop(handle); |