diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2010-06-02 22:04:39 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-07-05 11:16:08 -0700 |
| commit | 69d44cfd3e4d45b92a6ddea7227df030c120f871 (patch) | |
| tree | ad0adfedc700459d8304e17e4dad5825e6e69774 | |
| parent | d1491fb32619f09e2e2515588ea864aadcdda41a (diff) | |
| download | lwn-69d44cfd3e4d45b92a6ddea7227df030c120f871.tar.gz lwn-69d44cfd3e4d45b92a6ddea7227df030c120f871.zip | |
ext4: Make sure the MOVE_EXT ioctl can't overwrite append-only files
commit 1f5a81e41f8b1a782c68d3843e9ec1bfaadf7d72 upstream.
Dan Roseberg has reported a problem with the MOVE_EXT ioctl. If the
donor file is an append-only file, we should not allow the operation
to proceed, lest we end up overwriting the contents of an append-only
file.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | fs/ext4/move_extent.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 82c415be87a4..e86f91e678af 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -964,6 +964,9 @@ mext_check_arguments(struct inode *orig_inode, return -EINVAL; } + if (IS_IMMUTABLE(donor_inode) || IS_APPEND(donor_inode)) + return -EPERM; + /* Ext4 move extent does not support swapfile */ if (IS_SWAPFILE(orig_inode) || IS_SWAPFILE(donor_inode)) { ext4_debug("ext4 move extent: The argument files should " |