diff options
| author | Dan Rosenberg <dan.j.rosenberg@gmail.com> | 2010-05-15 11:27:37 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-05-26 14:32:09 -0700 |
| commit | 8493589f15804898970d9cfb650ea6d86f339fe3 (patch) | |
| tree | 7ac48556add6435a0ab5108510a848b7bdf3146a | |
| parent | 893bb29ec037b10287d127d037fd77e61b397420 (diff) | |
| download | lwn-8493589f15804898970d9cfb650ea6d86f339fe3.tar.gz lwn-8493589f15804898970d9cfb650ea6d86f339fe3.zip | |
Btrfs: check for read permission on src file in the clone ioctl
commit 5dc6416414fb3ec6e2825fd4d20c8bf1d7fe0395 upstream.
The existing code would have allowed you to clone a file that was
only open for writing
Signed-off-by: Chris Mason <chris.mason@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | fs/btrfs/ioctl.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 645a17927a8f..2c6ee6aacb26 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -964,12 +964,17 @@ static noinline long btrfs_ioctl_clone(struct file *file, unsigned long srcfd, ret = -EBADF; goto out_drop_write; } + src = src_file->f_dentry->d_inode; ret = -EINVAL; if (src == inode) goto out_fput; + /* the src must be open for reading */ + if (!(src_file->f_mode & FMODE_READ)) + goto out_fput; + ret = -EISDIR; if (S_ISDIR(src->i_mode) || S_ISDIR(inode->i_mode)) goto out_fput; |