diff options
| author | Hannes Reinecke <hare@suse.de> | 2010-05-04 16:49:21 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-05-12 15:03:13 -0700 |
| commit | 7c18009f1822fd261cb7549560b44e1ebad51a11 (patch) | |
| tree | 000d1aa5f92b8eae144a47494e0ce0d6d16996fb | |
| parent | a8717970e99de8f12cf65c00d9de3229138cde0e (diff) | |
| download | lwn-7c18009f1822fd261cb7549560b44e1ebad51a11.tar.gz lwn-7c18009f1822fd261cb7549560b44e1ebad51a11.zip | |
Enable retries for SYNCRONIZE_CACHE commands to fix I/O error
commit c213e1407be6b04b144794399a91472e0ef92aec upstream.
Some arrays are giving I/O errors with ext3 filesystems when
SYNCHRONIZE_CACHE gets a UNIT_ATTENTION. What is happening is that
these commands have no retries, so the UNIT_ATTENTION causes the
barrier to fail. We should be enable retries here to clear any
transient error and allow the barrier to succeed.
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/scsi/sd.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 255da53e5a01..bf1592098ccc 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1039,6 +1039,7 @@ static void sd_prepare_flush(struct request_queue *q, struct request *rq) { rq->cmd_type = REQ_TYPE_BLOCK_PC; rq->timeout = SD_TIMEOUT; + rq->retries = SD_MAX_RETRIES; rq->cmd[0] = SYNCHRONIZE_CACHE; rq->cmd_len = 10; } |