diff options
| author | Stuart Hayes <stuart_hayes@yahoo.com> | 2011-03-02 13:42:05 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-03-28 07:31:23 -0700 |
| commit | ecf63042d77be3fd68519499399064db35bc91cd (patch) | |
| tree | 0c9e00cc9b1da380afa665270058c04469b7e837 | |
| parent | a44ba30a832efbf9e48af31a5db8dc75f5a6663a (diff) | |
| download | lwn-ecf63042d77be3fd68519499399064db35bc91cd.tar.gz lwn-ecf63042d77be3fd68519499399064db35bc91cd.zip | |
dcdbas: force SMI to happen when expected
commit dd65c736d1b5312c80c88a64bf521db4959eded5 upstream.
The dcdbas driver can do an I/O write to cause a SMI to occur. The SMI handler
looks at certain registers and memory locations, so the SMI needs to happen
immediately. On some systems I/O writes are posted, though, causing the SMI to
happen well after the "outb" occurred, which causes random failures. Following
the "outb" with an "inb" forces the write to go through even if it is posted.
Signed-off-by: Stuart Hayes <stuart_hayes@yahoo.com>
Acked-by: Doug Warzecha <douglas_warzecha@dell.com>
Cc: Chuck Ebbert <cebbert@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/firmware/dcdbas.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c index 18d65fb42ee7..3abb51577a52 100644 --- a/drivers/firmware/dcdbas.c +++ b/drivers/firmware/dcdbas.c @@ -267,8 +267,10 @@ int dcdbas_smi_request(struct smi_cmd *smi_cmd) } /* generate SMI */ + /* inb to force posted write through and make SMI happen now */ asm volatile ( - "outb %b0,%w1" + "outb %b0,%w1\n" + "inb %w1" : /* no output args */ : "a" (smi_cmd->command_code), "d" (smi_cmd->command_address), |