diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2015-06-20 22:50:33 -0400 |
|---|---|---|
| committer | Willy Tarreau <w@1wt.eu> | 2015-09-18 13:52:12 +0200 |
| commit | c726e1d46177df427482b0b3e0f758083f83c50f (patch) | |
| tree | 79e50cfcdcb7bc1c1b3f30c38c2b569ba3c0a96f | |
| parent | d2d8cee6fdfec9355f41e35ab6a06d085f23ec58 (diff) | |
| download | lwn-c726e1d46177df427482b0b3e0f758083f83c50f.tar.gz lwn-c726e1d46177df427482b0b3e0f758083f83c50f.zip | |
ext4: call sync_blockdev() before invalidate_bdev() in put_super()
commit 89d96a6f8e6491f24fc8f99fd6ae66820e85c6c1 upstream.
Normally all of the buffers will have been forced out to disk before
we call invalidate_bdev(), but there will be some cases, where a file
system operation was aborted due to an ext4_error(), where there may
still be some dirty buffers in the buffer cache for the device. So
try to force them out to memory before calling invalidate_bdev().
This fixes a warning triggered by generic/081:
WARNING: CPU: 1 PID: 3473 at /usr/projects/linux/ext4/fs/block_dev.c:56 __blkdev_put+0xb5/0x16f()
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
(cherry picked from commit 5dedaea4936981382ec0d9833ad372ebd3d8af57)
Signed-off-by: Willy Tarreau <w@1wt.eu>
| -rw-r--r-- | fs/ext4/super.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 108515f58e82..045e7bf9c753 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -652,6 +652,7 @@ static void ext4_put_super(struct super_block *sb) dump_orphan_list(sb, sbi); J_ASSERT(list_empty(&sbi->s_orphan)); + sync_blockdev(sb->s_bdev); invalidate_bdev(sb->s_bdev); if (sbi->journal_bdev && sbi->journal_bdev != sb->s_bdev) { /* |