diff options
| author | Bryn M. Reeves <bmr@redhat.com> | 2009-11-12 18:31:54 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-01-22 15:18:27 -0800 |
| commit | 94249e60370f0094831ba673881222252d799257 (patch) | |
| tree | ca8f7e6f090c9035228a54a23c8580519b122cdd | |
| parent | 2db740cb364a38b6bf50e1c61dc6d9615bfe390c (diff) | |
| download | lwn-94249e60370f0094831ba673881222252d799257.tar.gz lwn-94249e60370f0094831ba673881222252d799257.zip | |
megaraid_sas: remove sysfs poll_mode_io world writeable permissions
commit bb7d3f24c71e528989501617651b669fbed798cb upstream.
/sys/bus/pci/drivers/megaraid_sas/poll_mode_io defaults to being
world-writable, which seems bad (letting any user affect kernel driver
behavior).
This turns off group and user write permissions, so that on typical
production systems only root can write to it.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/scsi/megaraid/megaraid_sas.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/megaraid/megaraid_sas.c b/drivers/scsi/megaraid/megaraid_sas.c index 507ccc682046..518712cc7253 100644 --- a/drivers/scsi/megaraid/megaraid_sas.c +++ b/drivers/scsi/megaraid/megaraid_sas.c @@ -3451,7 +3451,7 @@ out: return retval; } -static DRIVER_ATTR(poll_mode_io, S_IRUGO|S_IWUGO, +static DRIVER_ATTR(poll_mode_io, S_IRUGO|S_IWUSR, megasas_sysfs_show_poll_mode_io, megasas_sysfs_set_poll_mode_io); |