diff options
| author | Arjan van de Ven <arjan@linux.intel.com> | 2010-01-16 12:53:19 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-01-25 10:49:44 -0800 |
| commit | 5a20267b12fec85520acc1e839ee61f2ea16413d (patch) | |
| tree | 0e767614e3c5cbae6016497981d1f4b063378509 | |
| parent | f2fa92b29da64ead309293a048fe41776338a280 (diff) | |
| download | lwn-5a20267b12fec85520acc1e839ee61f2ea16413d.tar.gz lwn-5a20267b12fec85520acc1e839ee61f2ea16413d.zip | |
perf timechart: Use tid not pid for COMM change
commit 8f06d7e6e1bbfb32698d6d455583ab7460c090e2 upstream.
A process that changes its comm field, does this on a per kernel
task struct basis. The timechart tool used, incorrectly, the pid
to track this, and should have used the tid instead...
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <20100116125319.34ac3edd@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | tools/perf/builtin-timechart.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c index e8a510d935e5..4101afeb4675 100644 --- a/tools/perf/builtin-timechart.c +++ b/tools/perf/builtin-timechart.c @@ -275,7 +275,7 @@ static u64 cpus_pstate_state[MAX_CPUS]; static int process_comm_event(event_t *event) { - pid_set_comm(event->comm.pid, event->comm.comm); + pid_set_comm(event->comm.tid, event->comm.comm); return 0; } static int |