diff options
| author | H. Peter Anvin <hpa@zytor.com> | 2012-03-02 10:43:49 -0800 |
|---|---|---|
| committer | Willy Tarreau <w@1wt.eu> | 2012-03-17 11:14:51 +0100 |
| commit | 09735ec38bbd8391e137096cfec62e414ad96f27 (patch) | |
| tree | 6ccc31a96ff2a5319e2e94257f2b1126ab7f5e8f | |
| parent | fe8b46f4a788b8433237757cb941c6cdf5c0ed5d (diff) | |
| download | lwn-09735ec38bbd8391e137096cfec62e414ad96f27.tar.gz lwn-09735ec38bbd8391e137096cfec62e414ad96f27.zip | |
regset: Return -EFAULT, not -EIO, on host-side memory fault
commit 5189fa19a4b2b4c3bec37c3a019d446148827717 upstream.
There is only one error code to return for a bad user-space buffer
pointer passed to a system call in the same address space as the
system call is executed, and that is EFAULT. Furthermore, the
low-level access routines, which catch most of the faults, return
EFAULT already.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Roland McGrath <roland@hack.frob.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
| -rw-r--r-- | include/linux/regset.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/regset.h b/include/linux/regset.h index 5150fd16ef93..686f37327a49 100644 --- a/include/linux/regset.h +++ b/include/linux/regset.h @@ -339,7 +339,7 @@ static inline int copy_regset_to_user(struct task_struct *target, return -EOPNOTSUPP; if (!access_ok(VERIFY_WRITE, data, size)) - return -EIO; + return -EFAULT; return regset->get(target, regset, offset, size, NULL, data); } @@ -365,7 +365,7 @@ static inline int copy_regset_from_user(struct task_struct *target, return -EOPNOTSUPP; if (!access_ok(VERIFY_READ, data, size)) - return -EIO; + return -EFAULT; return regset->set(target, regset, offset, size, NULL, data); } |