diff options
| author | Jeff Layton <jlayton@redhat.com> | 2010-08-23 11:38:04 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-08-08 10:23:16 -0700 |
| commit | 39371f2a8a7c27a63882c1586c3ee72f05eb6527 (patch) | |
| tree | fb73ad983a1def19387a13f35617a791b20edfc0 | |
| parent | eda9d27e356873efbd5f071da1741fc74a842c2b (diff) | |
| download | lwn-39371f2a8a7c27a63882c1586c3ee72f05eb6527.tar.gz lwn-39371f2a8a7c27a63882c1586c3ee72f05eb6527.zip | |
cifs: check for NULL session password
commit 24e6cf92fde1f140d8eb0bf7cd24c2c78149b6b2 upstream.
It's possible for a cifsSesInfo struct to have a NULL password, so we
need to check for that prior to running strncmp on it.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | fs/cifs/connect.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index e15b09457a96..b6bb82ec278e 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -1605,6 +1605,7 @@ cifs_find_smb_ses(struct TCP_Server_Info *server, struct smb_vol *vol) MAX_USERNAME_SIZE)) continue; if (strlen(vol->username) != 0 && + ses->password != NULL && strncmp(ses->password, vol->password ? vol->password : "", MAX_PASSWORD_SIZE)) |