diff options
| author | Apollon Oikonomopoulos <apollon@noc.grnet.gr> | 2010-12-07 09:43:30 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-03-02 09:46:35 -0500 |
| commit | cfa3f57bab83b586b948fd40d3558243d55818b2 (patch) | |
| tree | 5ebe4b84cfa1be054d2457d8eb59235cce2d2be9 | |
| parent | f37c091b7f85f3f93b5eb79c4a4fa53ed1339f9e (diff) | |
| download | lwn-cfa3f57bab83b586b948fd40d3558243d55818b2.tar.gz lwn-cfa3f57bab83b586b948fd40d3558243d55818b2.zip | |
x25: decrement netdev reference counts on unload
commit 171995e5d82dcc92bea37a7d2a2ecc21068a0f19 upstream.
x25 does not decrement the network device reference counts on module unload.
Thus unregistering any pre-existing interface after unloading the x25 module
hangs and results in
unregister_netdevice: waiting for tap0 to become free. Usage count = 1
This patch decrements the reference counts of all interfaces in x25_link_free,
the way it is already done in x25_link_device_down for NETDEV_DOWN events.
Signed-off-by: Apollon Oikonomopoulos <apollon@noc.grnet.gr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | net/x25/x25_link.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/x25/x25_link.c b/net/x25/x25_link.c index e4e1b6e49538..8954783597c5 100644 --- a/net/x25/x25_link.c +++ b/net/x25/x25_link.c @@ -393,6 +393,7 @@ void __exit x25_link_free(void) list_for_each_safe(entry, tmp, &x25_neigh_list) { nb = list_entry(entry, struct x25_neigh, node); __x25_remove_neigh(nb); + dev_put(nb->dev); } write_unlock_bh(&x25_neigh_list_lock); } |