diff options
| author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2009-10-26 08:09:46 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-11-09 16:23:03 -0800 |
| commit | 85c60e5dfa4c00bb4deacc36cd719db557c9d2c6 (patch) | |
| tree | 508cde3994ff6a104f2419ef6fc04e62f54ec4d6 | |
| parent | 4886f073309eeb9d99d9f05d944f8b0874c60bbd (diff) | |
| download | lwn-85c60e5dfa4c00bb4deacc36cd719db557c9d2c6.tar.gz lwn-85c60e5dfa4c00bb4deacc36cd719db557c9d2c6.zip | |
NFSv4: Fix two unbalanced put_rpccred() issues.
commit 141aeb9f26f9f12f1584c128ce8697cdffb046e7 upstream.
Commits 29fba38b (nfs41: lease renewal) and fc01cea9 (nfs41: sequence
operation) introduce a couple of put_rpccred() calls on credentials for
which there is no corresponding get_rpccred().
See http://bugzilla.kernel.org/show_bug.cgi?id=14249
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | fs/nfs/nfs4proc.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 6c1534cdef1f..2aa239680425 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -3038,9 +3038,6 @@ static void nfs4_renew_done(struct rpc_task *task, void *data) if (time_before(clp->cl_last_renewal,timestamp)) clp->cl_last_renewal = timestamp; spin_unlock(&clp->cl_lock); - dprintk("%s calling put_rpccred on rpc_cred %p\n", __func__, - task->tk_msg.rpc_cred); - put_rpccred(task->tk_msg.rpc_cred); } static const struct rpc_call_ops nfs4_renew_ops = { @@ -4855,7 +4852,6 @@ void nfs41_sequence_call_done(struct rpc_task *task, void *data) nfs41_sequence_free_slot(clp, task->tk_msg.rpc_resp); dprintk("%s rpc_cred %p\n", __func__, task->tk_msg.rpc_cred); - put_rpccred(task->tk_msg.rpc_cred); kfree(task->tk_msg.rpc_argp); kfree(task->tk_msg.rpc_resp); |