summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoerg Roedel <joerg.roedel@amd.com>2009-06-16 12:23:58 +0200
committerJoerg Roedel <joerg.roedel@amd.com>2009-06-16 12:29:40 +0200
commitc79ee4e466dd12347f112e2af306dca35198458f (patch)
tree42c7a2fede416d9702a5affcf68ea198372590db
parentaa010efb7b6cd0dfbea8ecf37a6ab587dc2a8560 (diff)
downloadlwn-c79ee4e466dd12347f112e2af306dca35198458f.tar.gz
lwn-c79ee4e466dd12347f112e2af306dca35198458f.zip
dma-debug: fix off-by-one error in overlap function
This patch fixes a bug in the overlap function which returned true if one region ends exactly before the second region begins. This is no overlap but the function returned true in that case. Cc: stable@kernel.org Reported-by: Andrew Randrianasulu <randrik@mail.ru> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
-rw-r--r--lib/dma-debug.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index 3b93129a968c..a9b6b5c9e091 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -862,7 +862,7 @@ static inline bool overlap(void *addr, u64 size, void *start, void *end)
return ((addr >= start && addr < end) ||
(addr2 >= start && addr2 < end) ||
- ((addr < start) && (addr2 >= end)));
+ ((addr < start) && (addr2 > end)));
}
static void check_for_illegal_area(struct device *dev, void *addr, u64 size)