diff options
| author | Alan Cox <alan@linux.intel.com> | 2009-09-19 13:13:23 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-10-05 09:32:34 -0700 |
| commit | 08f30ff9811e59c08d1cee043ce55b2e862efe58 (patch) | |
| tree | 7adc35cbdcbb9759a93d06d8d43f5e44848ac3ee | |
| parent | 4260dc792fabfd20c8644fa9414b2ae48372365f (diff) | |
| download | lwn-08f30ff9811e59c08d1cee043ce55b2e862efe58.tar.gz lwn-08f30ff9811e59c08d1cee043ce55b2e862efe58.zip | |
tty: USB hangup is racy
commit d2b391822a11302add9e46476f3da4e18e6de84c upstream.
The USB layer uses tty_hangup to deal with unplugs of the physical hardware
(analogous to loss of carrier) and then frees the resources. However the
tty_hangup is asynchronous. As the hangup can sleep we can use tty_vhangup
which is the non async version to avoid freeing resources too early.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/usb/serial/usb-serial.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c index 99188c92068b..21dd72a5a715 100644 --- a/drivers/usb/serial/usb-serial.c +++ b/drivers/usb/serial/usb-serial.c @@ -1161,10 +1161,7 @@ void usb_serial_disconnect(struct usb_interface *interface) if (port) { struct tty_struct *tty = tty_port_tty_get(&port->port); if (tty) { - /* The hangup will occur asynchronously but - the object refcounts will sort out all the - cleanup */ - tty_hangup(tty); + tty_vhangup(tty); tty_kref_put(tty); } kill_traffic(port); |