summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMikulas Patocka <mpatocka@redhat.com>2009-06-22 10:12:13 +0100
committerAlasdair G Kergon <agk@redhat.com>2009-06-22 10:12:13 +0100
commit53b351f972a882ea8b6cdb19602535f1057c884a (patch)
tree0a3736a570dc7ff3c6ebf0993950a36a9784b142
parenta72986c562eeec3f7b992198c168f0f41606fe53 (diff)
downloadlwn-53b351f972a882ea8b6cdb19602535f1057c884a.tar.gz
lwn-53b351f972a882ea8b6cdb19602535f1057c884a.zip
dm mpath: flush keventd queue in destructor
The commit fe9cf30eb8186ef267d1868dc9f12f2d0f40835a moves dm table event submission from kmultipath queue to kernel kevent queue to avoid a deadlock. There is a possibility of race condition because kevent queue is not flushed in the multipath destructor. The scenario is: - some event happens and is queued to keventd - keventd thread is delayed due to scheuling latency or some other work - multipath device is destroyed - keventd now attempts to process work_struct that is residing in already released memory. The patch flushes the keventd queue in multipath constructor. I've already fixed similar bug in dm-raid1. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Signed-off-by: Alasdair G Kergon <agk@redhat.com> Cc: stable@kernel.org
-rw-r--r--drivers/md/dm-mpath.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 838f01b1dd30..92bdcbb7c935 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -848,6 +848,7 @@ static void multipath_dtr(struct dm_target *ti)
flush_workqueue(kmpath_handlerd);
flush_workqueue(kmultipathd);
+ flush_scheduled_work();
free_multipath(m);
}