summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Teigland <teigland@redhat.com>2008-11-17 12:28:48 -0600
committerMark Fasheh <mfasheh@suse.com>2008-12-01 14:46:45 -0800
commit07f9eebcdfaeefc8f807fa1bcce1d7c3ae6661b1 (patch)
tree838ab2a397e1edb3dcfb55b54144f9fb0524cb75
parent66f502a416f18cd36179290746aa53736c6b2828 (diff)
downloadlwn-07f9eebcdfaeefc8f807fa1bcce1d7c3ae6661b1.tar.gz
lwn-07f9eebcdfaeefc8f807fa1bcce1d7c3ae6661b1.zip
ocfs2: fix wake_up in unlock_ast
In ocfs2_unlock_ast(), call wake_up() on lockres before releasing the spin lock on it. As soon as the spin lock is released, the lockres can be freed. Signed-off-by: David Teigland <teigland@redhat.com> Signed-off-by: Mark Fasheh <mfasheh@suse.com>
-rw-r--r--fs/ocfs2/dlmglue.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index ec684426034b..6e6cc0a2e5f7 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -2841,9 +2841,8 @@ static void ocfs2_unlock_ast(void *opaque, int error)
lockres_clear_flags(lockres, OCFS2_LOCK_BUSY);
lockres->l_unlock_action = OCFS2_UNLOCK_INVALID;
- spin_unlock_irqrestore(&lockres->l_lock, flags);
-
wake_up(&lockres->l_event);
+ spin_unlock_irqrestore(&lockres->l_lock, flags);
mlog_exit_void();
}