diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2011-11-14 17:52:08 +0300 |
|---|---|---|
| committer | Willy Tarreau <w@1wt.eu> | 2012-02-11 15:37:57 +0100 |
| commit | 9f5e4da29bd67249fa708af443f9bbcb2328311b (patch) | |
| tree | 8166cc0572517466b689af031750bffaba405451 | |
| parent | 41503f12fe5f9ec58ae15845b30c1f3a3a4d68e2 (diff) | |
| download | lwn-9f5e4da29bd67249fa708af443f9bbcb2328311b.tar.gz lwn-9f5e4da29bd67249fa708af443f9bbcb2328311b.zip | |
hfs: add sanity check for file name length
commit bc5b8a9003132ae44559edd63a1623b7b99dfb68 upstream.
On a corrupted file system the ->len field could be wrong leading to
a buffer overflow.
Reported-and-acked-by: Clement LECIGNE <clement.lecigne@netasq.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Willy Tarreau <w@1wt.eu>
| -rw-r--r-- | fs/hfs/trans.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/hfs/trans.c b/fs/hfs/trans.c index e673a88b8ae7..b1ce4c7ad3fb 100644 --- a/fs/hfs/trans.c +++ b/fs/hfs/trans.c @@ -40,6 +40,8 @@ int hfs_mac2asc(struct super_block *sb, char *out, const struct hfs_name *in) src = in->name; srclen = in->len; + if (srclen > HFS_NAMELEN) + srclen = HFS_NAMELEN; dst = out; dstlen = HFS_MAX_NAMELEN; if (nls_io) { |